Skip to content

Features upgrade of Embedding model #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 11, 2025
Merged

Conversation

quic-amitraj
Copy link
Contributor

@quic-amitraj quic-amitraj commented May 27, 2025

  1. Added Pooling support to Embedding Model
  2. Added multiple seq_len support for the embedding model using QEffAutoModel
  3. Added test for pooling and multiple seq_len

@quic-amitraj quic-amitraj added the wip Work in progress label May 27, 2025
@quic-amitraj quic-amitraj self-assigned this May 27, 2025
@quic-amitraj quic-amitraj marked this pull request as ready for review June 2, 2025 11:27
@quic-amitraj quic-amitraj added ready for review and removed wip Work in progress labels Jun 2, 2025
@quic-amitraj quic-amitraj changed the title Added Pooling support to Embedding Model Feature upgrade of Embedding model Jun 2, 2025
@quic-amitraj quic-amitraj changed the title Feature upgrade of Embedding model Features upgrade of Embedding model Jun 2, 2025
@quic-amitraj quic-amitraj marked this pull request as draft June 4, 2025 05:56
@quic-amitraj quic-amitraj force-pushed the nlp_pooling branch 2 times, most recently from 6eec980 to 3c76e0b Compare June 9, 2025 10:21
@quic-amitraj quic-amitraj marked this pull request as ready for review June 9, 2025 10:22
Copy link
Contributor Author

@quic-amitraj quic-amitraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments addressed.

Copy link
Contributor Author

@quic-amitraj quic-amitraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated docstring in all module.

@quic-amitraj quic-amitraj force-pushed the nlp_pooling branch 4 times, most recently from 9419072 to f449fd2 Compare June 10, 2025 14:39
@quic-rishinr quic-rishinr merged commit 2514c0b into quic:main Jun 11, 2025
4 checks passed
asmigosw pushed a commit to asmigosw/efficient-transformers that referenced this pull request Jun 17, 2025
1. Added `Pooling` support to Embedding Model
2. Added multiple seq_len support for the embedding model using
`QEffAutoModel`
4. Added test for pooling and multiple seq_len

---------

Signed-off-by: Amit Raj <[email protected]>
Signed-off-by: Abukhoyer Shaik <[email protected]>
Co-authored-by: Abukhoyer Shaik <[email protected]>
asmigosw pushed a commit to asmigosw/efficient-transformers that referenced this pull request Jun 17, 2025
1. Added `Pooling` support to Embedding Model
2. Added multiple seq_len support for the embedding model using
`QEffAutoModel`
4. Added test for pooling and multiple seq_len

---------

Signed-off-by: Amit Raj <[email protected]>
Signed-off-by: Abukhoyer Shaik <[email protected]>
Co-authored-by: Abukhoyer Shaik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants