-
Notifications
You must be signed in to change notification settings - Fork 44
Features upgrade of Embedding model
#424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pooling
support to Embedding ModelEmbedding model
Embedding model
Embedding model
quic-rishinr
reviewed
Jun 5, 2025
6eec980
to
3c76e0b
Compare
quic-rishinr
requested changes
Jun 10, 2025
quic-amitraj
commented
Jun 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments addressed.
quic-amitraj
commented
Jun 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated docstring in all module.
9419072
to
f449fd2
Compare
quic-hemagnih
approved these changes
Jun 11, 2025
Signed-off-by: Amit Raj <[email protected]>
Signed-off-by: Amit Raj <[email protected]>
Signed-off-by: Amit Raj <[email protected]>
Signed-off-by: Amit Raj <[email protected]>
Signed-off-by: Amit Raj <[email protected]>
Signed-off-by: Amit Raj <[email protected]>
Signed-off-by: Amit Raj <[email protected]>
…e closest seq_len based on input_ids_len Signed-off-by: Amit Raj <[email protected]>
Signed-off-by: Amit Raj <[email protected]>
Signed-off-by: Amit Raj <[email protected]>
Signed-off-by: Amit Raj <[email protected]>
Signed-off-by: Amit Raj <[email protected]>
Signed-off-by: Amit Raj <[email protected]>
Signed-off-by: Abukhoyer Shaik <[email protected]>
0c4604d
to
5678b78
Compare
quic-rishinr
approved these changes
Jun 11, 2025
asmigosw
pushed a commit
to asmigosw/efficient-transformers
that referenced
this pull request
Jun 17, 2025
1. Added `Pooling` support to Embedding Model 2. Added multiple seq_len support for the embedding model using `QEffAutoModel` 4. Added test for pooling and multiple seq_len --------- Signed-off-by: Amit Raj <[email protected]> Signed-off-by: Abukhoyer Shaik <[email protected]> Co-authored-by: Abukhoyer Shaik <[email protected]>
asmigosw
pushed a commit
to asmigosw/efficient-transformers
that referenced
this pull request
Jun 17, 2025
1. Added `Pooling` support to Embedding Model 2. Added multiple seq_len support for the embedding model using `QEffAutoModel` 4. Added test for pooling and multiple seq_len --------- Signed-off-by: Amit Raj <[email protected]> Signed-off-by: Abukhoyer Shaik <[email protected]> Co-authored-by: Abukhoyer Shaik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pooling
support to Embedding ModelQEffAutoModel